Allow YOLO models in same directory #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To increase sharing of models with other UIs the YOLO models should not have to be split out into the bbox/ and segm/ folder. This fix only comes into action if the initial lookup in bbox or segm folder failed, allowing YOLO model sharing with other UIs like Automatic1111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The YOLO models must currently be split into the segm/ and bbox/ folders which does not allow to share the models with other nodes/UIs which use a unified folder
Solution
In case the initial path lookup using the bbox/ or segm/ folder fails/has no results it will instead check the parent folder and try to load it from there, making it possible to put files directly in the "ultralytics" folder instead of "ultralytics_segm" and "ultralytics_bbox"
Caveats
The UI will show every model twice using the bbox/ and segm/ prefix. I see no way to fix this without fundamental changes to the whole model-loading part. This also means that whoever puts the files in a shared folder must also be aware what is a segmentation model and what is a detection/box model an wire it accordingly.